Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mounter(ticdc): default value convert to the correct data type (#10804) #10826

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10804

What problem does this PR solve?

Issue Number: close #10803

What is changed and how it works?

  • convert the datum to the specific column type

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. labels Mar 20, 2024
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.0 This PR is cherry-picked to release-8.0 from a source PR. labels Mar 20, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.0@ba58ef9). Click here to learn what that means.
The diff coverage is 70.0000%.

Additional details and impacted files
Components Coverage Δ
cdc 61.8946% <0.0000%> (?)
dm 51.2555% <0.0000%> (?)
engine 63.3794% <0.0000%> (?)
Flag Coverage Δ
unit 57.5620% <70.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.0     #10826   +/-   ##
================================================
  Coverage               ?   57.5620%           
================================================
  Files                  ?        853           
  Lines                  ?     126891           
  Branches               ?          0           
================================================
  Hits                   ?      73041           
  Misses                 ?      48413           
  Partials               ?       5437           

@3AceShowHand
Copy link
Contributor

/test cdc-integration-kafka-test

Copy link
Contributor

ti-chi-bot bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit b81378b into pingcap:release-8.0 Mar 21, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.0 This PR is cherry-picked to release-8.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants