Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics(ticdc): fix slowest table metrics in scheduler (#10484) #10500

Merged
merged 3 commits into from
Jan 24, 2024
Merged

metrics(ticdc): fix slowest table metrics in scheduler (#10484) #10500

merged 3 commits into from
Jan 24, 2024

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 18, 2024 •
edited by CharlesCheung96
Loading

This is an automated cherry-pick of #10484

What problem does this PR solve?

Issue Number: close #10482, close #10449, close #10354

What is changed and how it works?

  1. Record the correct progress in slowestTablePullerResolvedTs
  2. For tables with equal checkpoints, set the table with the smallest resovedTs to the slowest table

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 18, 2024
Merged
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. label Jan 18, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-10484-to-release-6.5 branch from 6fa74cb to 8f00d7a Compare January 23, 2024 13:19
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2024
@CharlesCheung96 CharlesCheung96 mentioned this pull request Jan 23, 2024
Merged
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2024
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-10484-to-release-6.5 branch from 093f908 to bcae968 Compare January 23, 2024 13:26
@CharlesCheung96 CharlesCheung96 mentioned this pull request Jan 23, 2024
Closed
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 23, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 23, 2024
@CharlesCheung96
Copy link
Contributor

/retest

3 similar comments
@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 9eea15e into pingcap:release-6.5 Jan 24, 2024
10 checks passed
CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 24, 2024
@ti-chi-bot @CharlesCheung96
metrics(ticdc): fix slowest table metrics in scheduler (pingcap#10484) (
fbe4270 
pingcap#10500)

close pingcap#10354, close pingcap#10449, close pingcap#10482
CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 24, 2024
@ti-chi-bot @CharlesCheung96
metrics(ticdc): fix slowest table metrics in scheduler (pingcap#10484) (
ffe6fc7 
pingcap#10500)

close pingcap#10354, close pingcap#10449, close pingcap#10482
CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 1, 2024
@ti-chi-bot @CharlesCheung96
metrics(ticdc): fix slowest table metrics in scheduler (pingcap#10484) (
b4b0004 
pingcap#10500)

close pingcap#10354, close pingcap#10449, close pingcap#10482
CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 1, 2024
@ti-chi-bot @CharlesCheung96
metrics(ticdc): fix slowest table metrics in scheduler (pingcap#10484) (
737f203 
pingcap#10500)

close pingcap#10354, close pingcap#10449, close pingcap#10482
CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 7, 2024
@ti-chi-bot @CharlesCheung96
metrics(ticdc): fix slowest table metrics in scheduler (pingcap#10484) (
7d86c1b 
pingcap#10500)

close pingcap#10354, close pingcap#10449, close pingcap#10482
CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 26, 2024
@ti-chi-bot @CharlesCheung96
metrics(ticdc): fix slowest table metrics in scheduler (pingcap#10484) (
77ba5f5 
pingcap#10500)

close pingcap#10354, close pingcap#10449, close pingcap#10482
CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 26, 2024
@ti-chi-bot @CharlesCheung96
metrics(ticdc): fix slowest table metrics in scheduler (pingcap#10484) (
ae0e285 
pingcap#10500)

close pingcap#10354, close pingcap#10449, close pingcap#10482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

Assignees

@CharlesCheung96 CharlesCheung96

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-chi-bot @CharlesCheung96