-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api(ticdc): only update upstreamInfo that has changed (#10422) #10452
Merged
ti-chi-bot
merged 3 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-10422-to-release-7.5
Feb 9, 2024
Merged
api(ticdc): only update upstreamInfo that has changed (#10422) #10452
ti-chi-bot
merged 3 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-10422-to-release-7.5
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
labels
Jan 11, 2024
ti-chi-bot
bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jan 11, 2024
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Feb 1, 2024
CharlesCheung96
force-pushed
the
cherry-pick-10422-to-release-7.5
branch
from
February 9, 2024 06:18
4ffd512
to
5f62c4e
Compare
ti-chi-bot
bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Feb 9, 2024
CharlesCheung96
approved these changes
Feb 9, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/retest |
1 similar comment
/retest |
CharlesCheung96
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Feb 26, 2024
CharlesCheung96
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10422
What problem does this PR solve?
Issue Number: close #10430
What is changed and how it works?
there are two apis that update or create upstream information:
And, the expected usage of these apis is:
Before this PR, when a changefeed is created, cdc always updates the uptream information, regardless of whether the uptream changes. As a result, when different ChangeFeeds are created concurrently, cdc conflicts with concurrent updates to the same upstream key.
To solve this issue, we should only update upstreamInfo that has changed when creating changefeed.
Besides, cdc did not perform any checks when updating changefeed info:
tiflow/pkg/etcd/etcd.go
Line 513 in c6b3fec
To prevent concurrent updates to the same changefeed, we should compare the versions of the info and status keys.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note