Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api(ticdc): only update upstreamInfo that has changed (#10422) #10450

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10422

What problem does this PR solve?

Issue Number: close #10430

What is changed and how it works?

there are two apis that update or create upstream information:

  1. create changfeed and upstreamPUT /api/v2/changefeeds/{changefeed_id}
  2. update changefeed and upstream POST /api/v2/changefeeds

And, the expected usage of these apis is:

  1. Avoid modifying the same changefeed concurrently .
  2. Avoid modifying the same upstream concurrently.

Before this PR, when a changefeed is created, cdc always updates the uptream information, regardless of whether the uptream changes. As a result, when different ChangeFeeds are created concurrently, cdc conflicts with concurrent updates to the same upstream key.

To solve this issue, we should only update upstreamInfo that has changed when creating changefeed.


Besides, cdc did not perform any checks when updating changefeed info:

resp, err := c.Client.Txn(ctx, txnEmptyCmps, opsThen, TxnEmptyOpsElse)

To prevent concurrent updates to the same changefeed, we should compare the versions of the info and status keys.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`Fix a issue that TiCDC return ErrChangeFeedAlreadyExists when changefeeds are created concurrently`.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 11, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 11, 2024
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-10422-to-release-6.5 branch from 6d22203 to 50cbbba Compare January 23, 2024 13:57
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 23, 2024
@CharlesCheung96
Copy link
Contributor

/retest

11 similar comments
@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest
/retest

@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-10422-to-release-6.5 branch from 50cbbba to 2d22e7f Compare January 24, 2024 16:47
@CharlesCheung96
Copy link
Contributor

/test all

@CharlesCheung96
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit f4ff47d into pingcap:release-6.5 Jan 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants