sink-to-mysql(cdc) simplify conflict detector, prevent workload skew issue #10376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issue Signed-off-by: zhangjinpeng1987 <[email protected]>
Signed-off-by: zhangjinpeng1987 <[email protected]>
zhangjinpeng87
requested review from
sdojjy,
3AceShowHand,
hicqu and
hongyunyan
ti-chi-bot
bot
added
release-note-none
Signed-off-by: zhangjinpeng1987 <[email protected]>
Signed-off-by: zhangjinpeng1987 <[email protected]>
|
/test cdc-integration-storage-test |
|
/test dm-integration-test |
asddongmen
reviewed
Dec 28, 2023
asddongmen
approved these changes
Dec 28, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
| if resolved && assignedTo == assignedToAny { | ||
| assignedTo = n.RandWorkerID() | ||
| func (n *Node) maybeReadyToRun() { | ||
| if ok := n.checkReadiness(); ok { |
There was a problem hiding this comment.
When a large number of small transactions are in conflict, does performance degrade significantly?
There was a problem hiding this comment.
It is suppose not fast in the case of there are a large number of small transactions have conflict, no matter what you do.
|
/test dm-integration-test |
hicqu
approved these changes
Jan 2, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, hicqu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
3AceShowHand
added a commit
to 3AceShowHand/tiflow
that referenced
this pull request
Feb 7, 2024
…ad skew issue (pingcap#10376)" This reverts commit 9e0cacf.
3AceShowHand
added a commit
to 3AceShowHand/tiflow
that referenced
this pull request
Feb 26, 2024
…oad skew issue (pingcap#10376)" This reverts commit b1a9473.
3AceShowHand
added a commit
to 3AceShowHand/tiflow
that referenced
this pull request
Feb 26, 2024
…ad skew issue (pingcap#10376)" This reverts commit 9e0cacf.
3AceShowHand
added a commit
to 3AceShowHand/tiflow
that referenced
this pull request
Feb 27, 2024
…ad skew issue (pingcap#10376)" This reverts commit 9e0cacf.
3AceShowHand
added a commit
to 3AceShowHand/tiflow
that referenced
this pull request
Feb 28, 2024
…ad skew issue (pingcap#10376)" This reverts commit 9e0cacf.
ti-chi-bot
added
the
needs-cherry-pick-release-6.5
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Mar 14, 2024
Signed-off-by: ti-chi-bot <[email protected]>
CharlesCheung96
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Mar 20, 2024
CharlesCheung96
added a commit
to CharlesCheung96/tiflow
that referenced
this pull request
Apr 7, 2024
…ad skew issue (pingcap#10376) (pingcap#10780)" This reverts commit 2631409.
ti-chi-bot
removed
the
needs-cherry-pick-release-6.5
CharlesCheung96
added a commit
to CharlesCheung96/tiflow
that referenced
this pull request
Apr 9, 2024
…ad skew issue (pingcap#10376)" This reverts commit 9e0cacf.
This was referenced Apr 9, 2024
ti-chi-bot
removed
needs-cherry-pick-release-7.5
CharlesCheung96
added a commit
to CharlesCheung96/tiflow
that referenced
this pull request
Apr 18, 2024
…ad skew issue (pingcap#10376) (pingcap#10779)" This reverts commit c43300c.
CharlesCheung96
added a commit
to CharlesCheung96/tiflow
that referenced
this pull request
Apr 18, 2024
…ad skew issue (pingcap#10376) (pingcap#10778)" This reverts commit 2c55c0e.
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Apr 18, 2024
…ad skew issue (pingcap#10376)" This reverts commit 9e0cacf.
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Apr 18, 2024
…ad skew issue (pingcap#10376)" This reverts commit 9e0cacf.
CharlesCheung96
added a commit
to CharlesCheung96/tiflow
that referenced
this pull request
Apr 18, 2024
…ad skew issue (pingcap#10376) (pingcap#10779)" This reverts commit c43300c.
This was referenced Apr 22, 2024
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Apr 26, 2024
…ad skew issue (pingcap#10376)" This reverts commit 9e0cacf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10341
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note