ddl (ticdc): support replicate ddl in BDR mode #10299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/work-in-progress
ti-chi-bot
bot
added
size/L
ti-chi-bot
bot
added
size/XL
asddongmen
changed the title
asddongmen
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
3AceShowHand
reviewed
Jan 3, 2024
|
/retest |
3AceShowHand
approved these changes
Jan 4, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/retst |
|
/retest |
CharlesCheung96
approved these changes
Jan 4, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: lance6716 <[email protected]>
|
/retest |
6 tasks
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10301
What is changed and how it works?
Only replicate DDL with
BDRRolePrimaryas the role in BDR mode changefeed.Check List
Tests
Please take a look at the newly added integration test case.
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note