-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: parse metadata without flavor #10155
Merged
ti-chi-bot
merged 7 commits into
pingcap:master
from
GMHDBJD:parseMetadataWithoutFlavor
Dec 11, 2023
Merged
dm: parse metadata without flavor #10155
ti-chi-bot
merged 7 commits into
pingcap:master
from
GMHDBJD:parseMetadataWithoutFlavor
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Nov 24, 2023
ti-chi-bot
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Dec 5, 2023
/retest |
/retest |
/retest |
lance6716
approved these changes
Dec 8, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Dec 8, 2023
okJiang
approved these changes
Dec 8, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Dec 8, 2023
/retest |
1 similar comment
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4287
DM on cloud could not specify MariaDB flavor now, so parse with empty flavor
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note