Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: parse metadata without flavor #10155

Merged
merged 7 commits into from
Dec 11, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Nov 24, 2023

What problem does this PR solve?

Issue Number: close #4287
DM on cloud could not specify MariaDB flavor now, so parse with empty flavor

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 5, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 5, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 5, 2023

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 8, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 8, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-08 08:46:27.244331929 +0000 UTC m=+278.281558854: ☑️ agreed by lance6716.
  • 2023-12-08 09:10:12.737352302 +0000 UTC m=+1703.774579214: ☑️ agreed by okJiang.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 11, 2023

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 11, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 8589065 into pingcap:master Dec 11, 2023
14 checks passed
lichunzhu pushed a commit to lichunzhu/tiflow that referenced this pull request Dec 25, 2023
lichunzhu pushed a commit that referenced this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refine code
3 participants