Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up all kafka sink metrics by maintain broker information #4966

Closed
Tracked by #4483
3AceShowHand opened this issue Mar 21, 2022 · 0 comments · Fixed by #4969
Closed
Tracked by #4483

clean up all kafka sink metrics by maintain broker information #4966

3AceShowHand opened this issue Mar 21, 2022 · 0 comments · Fixed by #4969
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@3AceShowHand
Copy link
Contributor

3AceShowHand commented Mar 21, 2022 •
edited
Loading 

[2022/03/18 18:54:01.275 +00:00] [WARN] [metrics.go:279] ["clean up broker metrics failed"] [error="read tcp 10.233.127.131:38712->10.233.64.161:9092: i/o timeout"]

when cleaning up the Kafka metrics, broker information is required. But if Kafka brokers are unreachable, metrics may not be removed. This can be solved by always maintain broker information in the metrics collector.
@3AceShowHand 3AceShowHand mentioned this issue Mar 21, 2022
Open
29 tasks
@3AceShowHand 3AceShowHand added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement. good-first-issue labels Mar 21, 2022
@3AceShowHand 3AceShowHand mentioned this issue Mar 21, 2022
Merged
@ti-chi-bot ti-chi-bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed good-first-issue labels Mar 22, 2022
ti-chi-bot pushed a commit that referenced this issue Mar 22, 2022
@3AceShowHand
[DNM] cdc/kafka: fix kafka metrics collector (#4969)
a240cd0 
close #4966
@ti-chi-bot ti-chi-bot mentioned this issue Mar 22, 2022
Merged
ti-chi-bot added a commit that referenced this issue Mar 28, 2022
@ti-chi-bot
cdc/kafka: fix kafka metrics collector (#4969) (#4989)
3b46dc1 
close #4966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cdc/kafka: fix kafka metrics collector 3AceShowHand/tiflow
2 participants
@3AceShowHand @ti-chi-bot