Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A scenario that TiCDC could have more than one owner #4051

Closed
Tracked by #3844
amyangfei opened this issue Dec 24, 2021 · 3 comments · Fixed by #7334
Closed
Tracked by #3844

A scenario that TiCDC could have more than one owner #4051

amyangfei opened this issue Dec 24, 2021 · 3 comments · Fixed by #7334
Assignees
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@amyangfei
Copy link
Contributor

amyangfei commented Dec 24, 2021

What did you do?

  1. Create two ticdc servers
  2. Delete the owner key of the ticdc owner in etcd. /tidb/cdc/owner/<lease-id>
  3. Observe another ticdc server will become owner, and the old owner is still running.

What did you expect to see?

The old owner could detect this behavior.

What did you see instead?

Two owner exist.

NOTE: this is an unexpected user operation, if we don't think it is a bug, we must forbid it.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

TiCDC version (execute cdc version):

master@aa6f3c6e5ccf1dd5578de35a4a946712e9ef4ef9

@amyangfei amyangfei added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Dec 24, 2021
@lance6716
Copy link
Contributor

lance6716 commented Dec 28, 2021

why the old owner can't know the leadership has been changed through watch?

@asddongmen
Copy link
Contributor

I will do a investigation on this issue.

@asddongmen asddongmen added the affects-6.1 This bug affects the 6.1.x(LTS) versions. label Sep 26, 2022
@asddongmen asddongmen removed the affects-6.1 This bug affects the 6.1.x(LTS) versions. label Sep 27, 2022
@asddongmen
Copy link
Contributor

This issue is fixed in >= v6.3.0, and we do not cherrypick it to the older version since we consider it's an malicious behavior and we should have no guarantee in such scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
3 participants