Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unlock-ddl-lock for Optimistic Sharding DDL #3789

Closed
GMHDBJD opened this issue Dec 8, 2021 · 0 comments · Fixed by #4883
Closed

Support unlock-ddl-lock for Optimistic Sharding DDL #3789

GMHDBJD opened this issue Dec 8, 2021 · 0 comments · Fixed by #4883
Assignees
@lichunzhu
Labels
area/dm Issues or PRs related to DM. type/feature Issues about a new feature

Comments

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Dec 8, 2021

Is your feature request related to a problem?

#3592

If meets a conflict DDL in optimistic mode, we can not manually let worker execute/skip it by unlock-ddl-lock like we do in pessimistic mode.

Describe the feature you'd like

Support unlock-ddl-lock for Optimistic Sharding DDL
e.g.

unlock-ddl-lock <lock-ID> skip -s source -d schema -t table
unlock-ddl-lock <lock-ID> execute -s source -d schema -t table

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response
@GMHDBJD GMHDBJD added the subject/new-feature Denotes an issue or pull request adding a new feature. label Dec 8, 2021
@lichunzhu lichunzhu added the area/dm Issues or PRs related to DM. label Dec 10, 2021
@lichunzhu lichunzhu self-assigned this Dec 14, 2021
@lichunzhu lichunzhu mentioned this issue Dec 27, 2021
Merged
@lance6716 lance6716 added type/feature Issues about a new feature and removed subject/new-feature Denotes an issue or pull request adding a new feature. labels Feb 9, 2022
ti-chi-bot pushed a commit that referenced this issue Mar 11, 2022
@lichunzhu
Optimistic: support unlock-ddl-lock for Optimistic Sharding DDL (#4087)
92fc4c4 
ref #3789
@lichunzhu lichunzhu mentioned this issue Mar 14, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Mar 17, 2022
@lichunzhu
dm/optimistic: make errors which isn't sync error handled by 'binlog …
b0e6b2a 
…skip' command (#4883)

close #3789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lichunzhu lichunzhu

Labels
area/dm Issues or PRs related to DM. type/feature Issues about a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dm/optimistic: make errors which isn't sync error handled by 'binlog skip' command lichunzhu/tiflow
3 participants
@lance6716 @lichunzhu @GMHDBJD