Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the fail start of tiflash because of the zero division when getting cpu number (#9602) #9627

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Fix the fail start of tiflash because of the zero division when getting cpu number (#9602) #9627

merged 5 commits into from
Dec 9, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9602

What problem does this PR solve?

Issue Number: close #9212

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the that fail to start tiflash because of the zero division when getting cpu number

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 15, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 15, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 15, 2024
@xzhangxian1008
Copy link
Contributor

/run-all-tests

1 similar comment
@xzhangxian1008
Copy link
Contributor

/run-all-tests

@xzhangxian1008
Copy link
Contributor

/retest

3 similar comments
@xzhangxian1008
Copy link
Contributor

/retest

@xzhangxian1008
Copy link
Contributor

/retest

@xzhangxian1008
Copy link
Contributor

/retest

@xzhangxian1008
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024
@purelind
Copy link
Collaborator

purelind commented Dec 1, 2024

/retest

@purelind
Copy link
Collaborator

purelind commented Dec 1, 2024

/test pull-integration-test

@xzhangxian1008
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2024
xzhangxian1008
xzhangxian1008 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 9, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 9, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lloyd-Pottiger, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 9, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-09 02:41:35.237876031 +0000 UTC m=+233485.326678574: ☑️ agreed by xzhangxian1008.
  • 2024-12-09 03:01:22.306032005 +0000 UTC m=+234672.394834548: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit f12b255 into pingcap:release-6.5 Dec 9, 2024
4 checks passed
@xzhangxian1008 xzhangxian1008 deleted the cherry-pick-9602-to-release-6.5 branch December 10, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Assignees

@xzhangxian1008 xzhangxian1008

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @xzhangxian1008 @purelind @Lloyd-Pottiger @JaySon-Huang