Storage: Fix getSquashDeleteRange does not return correctly squashed key-range when using common-handle

[JaySon-Huang]

What problem does this PR solve?

Issue Number: close #9529

Problem Summary:

we get the "suqash delete range" to estimate whether there are sufficient delete rows that we need to compact data in background thread.

tiflash/dbms/src/Storages/DeltaMerge/DeltaMergeStore_InternalBg.cpp

Lines 526 to 528 in ce0d411

	auto actual_delete_range = snap->delta->getSquashDeleteRange().shrink(segment_range);
	if (actual_delete_range.none())
	return false;

In ColumnFileSetSnapshot::getSquashDeleteRange, it use the member variable is_common_handle, rowkey_column_size to generate the rowkey range.
But actually those two variable are not set correctly. is_common_handle is always false in ColumnFileSetSnapshot

tiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileSetSnapshot.cpp

Lines 21 to 30 in ce0d411

	RowKeyRange ColumnFileSetSnapshot::getSquashDeleteRange() const
	{
	RowKeyRange squashed_delete_range = RowKeyRange::newNone(is_common_handle, rowkey_column_size);
	for (const auto & column_file : column_files)
	{
	if (auto * f_delete = column_file->tryToDeleteRange(); f_delete)
	squashed_delete_range = squashed_delete_range.merge(f_delete->getDeleteRange());
	}
	return squashed_delete_range;
	}

So when the table use common-handle, shouldCompactDeltaWithStable always returns false, and the segment background gc is not GC in timely

What is changed and how it works?

Storage: Fix `getSquashDeleteRange` does not return correctly squashed key-range when using common-handle

• Remove unused variable ColumnFileSetSnapshot::{is_common_handle, rowkey_column_size}
• Pass the correct is_common_handle, rowkey_column_size in function shouldCompactDeltaWithStable
• Add check for rowkey-range is_common_handle in DMFilePackFilter

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Improve the data background GC speed on clustered-index table
提升聚簇索引的表后台回收过期数据的速度

[Lloyd-Pottiger]

lgtm

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-15 09:14:46.115885779 +0000 UTC m=+348883.264795609: ☑️ agreed by Lloyd-Pottiger.
• 2024-10-15 09:38:11.81892239 +0000 UTC m=+350288.967832214: ☑️ agreed by JinheLin.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #9541.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #9542.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #9565.