-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage: Abort adding vector index if encryption enabled #9504
Storage: Abort adding vector index if encryption enabled #9504
Conversation
Is it possible to still create the vector index file while encyption is enabled? Looks like setting create_new_encryption_info may resolve the issue I guess. I'm worried about aborting the index may affect dedicated tier or serverless. |
@breezewish After fixing the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold |
What problem does this PR solve?
Issue Number: close #9505, ref #9032
Problem Summary:
Encryption-at-rest is not compatible with building vector-index. We need more tests.
What is changed and how it works?
Encryption-at-rest is not compatible with building vector-index. We need more tests. Abort adding vector-index when encryption-at-rest is enabled in tiflash for now.
One of the reason is
DMFileV3IncrementWriter::writeAndIncludeMetaFile
callWriteBufferFromWritableFileBuilder::buildPtr(..., /* create_new_encryption_info */ true, ...)
and it renew the encryption_info of the DMFile. It causes the encryption_info mismatch after generating the new DMFile meta v1.There is still something wrong after fixing it. Still under investigation.
Other:
Add info level logging message when vector search is performed in tiflash.
Check List
Tests
Side effects
Documentation
Release note