Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Fix vector index not used #9503

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

breezewish
Copy link
Member

What problem does this PR solve?

Issue Number: ref #9032

Problem Summary:

What is changed and how it works?

Fix ANNIndexInfo is not utilized when TiDB specifies it

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
breezewish Wenxuan
Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 8, 2024
@JaySon-Huang JaySon-Huang requested a review from JinheLin October 8, 2024 09:38
Copy link
Contributor

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 09:37:57.058438006 +0000 UTC m=+952432.478651018: ☑️ agreed by JaySon-Huang.
  • 2024-10-08 10:01:52.342159304 +0000 UTC m=+953867.762372316: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit 02784a4 into pingcap:master Oct 8, 2024
5 checks passed
@breezewish breezewish deleted the wenxuan/vector/fix_1 branch October 8, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants