Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Do not physical drop table after tiflash replica is set to 0 #9440

Merged
merged 3 commits into from
Sep 19, 2024
Merged

ddl: Do not physical drop table after tiflash replica is set to 0 #9440

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c535e1d
Not physical drop table after tiflash replica set to 0
JaySon-Huang Sep 19, 2024
2749d63
Save replica number
JaySon-Huang Sep 19, 2024
e170fbb
fix
JaySon-Huang Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dbms/src/TiDB/Schema/SchemaBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,11 @@ void SchemaBuilder<Getter, NameMapper>::applySetTiFlashReplica(DatabaseID databa
return;
}

applyDropTable(database_id, table_id, "SetTiFlashReplica-0");
// We can not mark the table is safe to be physically drop from the tiflash instances when
// the number of tiflash replica is set to be 0.
// There could be a concurrent issue that cause data loss. Check the following link for details:
// https://github.com/pingcap/tiflash/issues/9438#issuecomment-2360370761
// applyDropTable(database_id, table_id, "SetTiFlashReplica-0");
return;
}

Expand Down