-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UniPS: Catch exception when dumping incr snapshot #9407
Conversation
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
dbms/src/Storages/Page/V3/CheckpointFile/CPManifestFileWriter.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Calvin Neo <[email protected]>
Co-authored-by: jinhelin <[email protected]>
Co-authored-by: jinhelin <[email protected]>
Co-authored-by: jinhelin <[email protected]>
Co-authored-by: jinhelin <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
dbms/src/Storages/Page/V3/Universal/UniversalPageStorageService.cpp
Outdated
Show resolved
Hide resolved
= writer->writeEditsAndApplyCheckpointInfo(edit_from_mem, compact_opts, options.only_upload_manifest); | ||
data_file_paths = writer->writeSuffix(); | ||
fiu_do_on(FailPoints::force_checkpoint_dump_throw_datafile, { | ||
throw Exception(ErrorCodes::LOGICAL_ERROR, "fake checkpoint write exception"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit change
throw Exception(ErrorCodes::LOGICAL_ERROR, "fake checkpoint write exception"); | |
throw Exception(ErrorCodes::FAIL_POINT_ERROR, "fake checkpoint write exception"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be LOGICAL_ERROR. Because there is another error ErrorCodes::REGION_DATA_SCHEMA_UPDATED
which could make prehandle to retry. So error codes matters here.
/retest |
/hold |
@CalvinNeo In summary:
|
Co-authored-by: JaySon <[email protected]>
Co-authored-by: JaySon <[email protected]>
Co-authored-by: JaySon <[email protected]>
Co-authored-by: JaySon <[email protected]>
Co-authored-by: JaySon <[email protected]>
Co-authored-by: JaySon <[email protected]>
…e.cpp Co-authored-by: JaySon <[email protected]>
Got it |
/unhold |
@CalvinNeo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…gcap#284) Signed-off-by: Calvin Neo <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: JaySon <[email protected]>
What problem does this PR solve?
Issue Number: close #9406, close #9098
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note