Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storages: Skip filter if all data match in Min-Max index #9318

Merged
merged 14 commits into from
Aug 22, 2024
Merged

Storages: Skip filter if all data match in Min-Max index #9318

merged 14 commits into from
Aug 22, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Aug 13, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9103

Problem Summary:

What is changed and how it works?

1. Add RSResult in Block.
2. Check RSResult in FilterTransformAction.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2024
@CalvinNeo
Copy link
Member

@coderabbitai review

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2024
@JinheLin JinheLin force-pushed the skip_filter_if_all2 branch from 440e4d3 to a005a0e Compare August 14, 2024 13:59
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2024
@JinheLin JinheLin force-pushed the skip_filter_if_all2 branch from eed9833 to bead125 Compare August 16, 2024 07:25
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2024
@JinheLin JinheLin changed the title WIP: test Storages: Skip filter if all data match in Min-Max index Aug 19, 2024
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Aug 19, 2024
Lloyd-Pottiger
Lloyd-Pottiger approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 19, 2024
@JinheLin JinheLin force-pushed the skip_filter_if_all2 branch from d201dfc to c4664ad Compare August 21, 2024 10:34
@JinheLin JinheLin requested a review from JaySon-Huang August 22, 2024 08:05
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-19 06:31:37.403877482 +0000 UTC m=+160692.538327601: ☑️ agreed by Lloyd-Pottiger.
  • 2024-08-22 15:04:13.091518221 +0000 UTC m=+450648.225968341: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 2652edb into pingcap:master Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using the filtering results of rough indexes to reduce the calculation of filters
4 participants
@JinheLin @CalvinNeo @JaySon-Huang @Lloyd-Pottiger