-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disagg: Fix the issue that lifetime of read-snapshots in WN may be longer than expected (#9297) #9317
Merged
ti-chi-bot
merged 3 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-9297-to-release-7.5
Aug 13, 2024
Merged
Disagg: Fix the issue that lifetime of read-snapshots in WN may be longer than expected (#9297) #9317
ti-chi-bot
merged 3 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-9297-to-release-7.5
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
labels
Aug 13, 2024
Merged
12 tasks
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Aug 13, 2024
ti-chi-bot
bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
do-not-merge/cherry-pick-not-approved
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Aug 13, 2024
ti-chi-bot
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Aug 13, 2024
JinheLin
approved these changes
Aug 13, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Aug 13, 2024
Lloyd-Pottiger
approved these changes
Aug 13, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Aug 13, 2024
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9297
What problem does this PR solve?
Issue Number: close #9298
Problem summary:
Snapshot of each SegmentReadTask will be released after FetchDisaggPages is called. But for some segments with no ColumnFileTiny or ColumnFileInMemory to fetch, FetchDisaggPages will never be called.
What is changed and how it works?
Notes:
Check List
Tests
Side effects
Documentation
Release note