Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UniPS: Provide more information when meets exception in updateLocalCacheForRemotePage #9311

Merged
merged 13 commits into from
Aug 12, 2024
Merged

UniPS: Provide more information when meets exception in updateLocalCacheForRemotePage #9311

merged 13 commits into from
Aug 12, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Aug 12, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #9307

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
a
7819b22 
Signed-off-by: Calvin Neo <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 12, 2024
@JaySon-Huang
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2024
JinheLin
JinheLin reviewed Aug 12, 2024
View reviewed changes
dbms/src/Storages/Page/V3/PageDirectory.cpp Outdated
if unlikely (last_iter == entries.end() || !last_iter->second.isEntry())
{
FmtBuffer buf;
for (const auto & e : entries)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also have a question: what's the size of entries normally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case, the size is 2

@CalvinNeo CalvinNeo requested a review from JinheLin August 12, 2024 06:43
@CalvinNeo
a
1ecc5b7 
Signed-off-by: Calvin Neo <[email protected]>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Aug 12, 2024 •
edited
Loading

/hold

You hold this because you want to add some more logs, or because you want to attach the fix for jemalloc cmake? @JaySon-Huang

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2024
@JaySon-Huang
Copy link
Contributor

@CalvinNeo
I thought that issue could be reproduced by adding some unit tests. But after writing those cases in gtest_remote_read.cpp, I found it can not reproduce the issue.

@JaySon-Huang
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2024
JaySon-Huang
JaySon-Huang approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 12, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-12 06:03:18.117479073 +0000 UTC m=+161482.820948716: ☑️ agreed by Lloyd-Pottiger.
  • 2024-08-12 08:33:58.445214292 +0000 UTC m=+170523.148683932: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

BTW, the best way to locate data corruption of PageStorage restore, is keep the "wal" of PageStorage and replay it locally to check the entries written in the "wal". The message dump from the in-memory PageDirectory already lost some information.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 12, 2024

@CalvinNeo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1e5474b into pingcap:master Aug 12, 2024
5 checks passed
yongman pushed a commit to yongman/tiflash that referenced this pull request Sep 13, 2024
@CalvinNeo @JaySon-Huang @ti-chi-bot
UniPS: Provide more information when meets exception in updateLocalCa…
3835e2a 
…cheForRemotePage (pingcap#9311) (pingcap#265)

Signed-off-by: Calvin Neo <[email protected]>
Co-authored-by: JaySon-Huang <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@JinheLin JinheLin Awaiting requested review from JinheLin

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CalvinNeo @JaySon-Huang @JinheLin @Lloyd-Pottiger