Fix the wrong result bug when casting string as datetime with time zone or illegal chars #9255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
/run-all-tests |
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
size/M
|
/run-all-tests |
solotzg
changed the title
ti-chi-bot
bot
added
release-note
Signed-off-by: Zhigao Tong <[email protected]>
|
/run-all-tests |
guo-shaoge
approved these changes
Aug 8, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
windtalker
reviewed
Aug 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
bot
added
needs-cherry-pick-release-8.1
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Aug 26, 2024
Signed-off-by: ti-chi-bot <[email protected]>
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
…ne or illegal chars (#9255) (#9354) close #8754 Fix the wrong result bug when casting string as datetime with time zone or illegal chars - func `getFracIndex` ignore time zone. - func `parseFrac` ignore illegal suffix after microsecond format. Signed-off-by: Zhigao Tong <[email protected]> Co-authored-by: TONG,Zhigao <[email protected]> Co-authored-by: Zhigao Tong <[email protected]> Co-authored-by: TONG, Zhigao <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
…ne or illegal chars (#9255) (#9352) close #8754 Fix the wrong result bug when casting string as datetime with time zone or illegal chars - func `getFracIndex` ignore time zone. - func `parseFrac` ignore illegal suffix after microsecond format. Signed-off-by: Zhigao Tong <[email protected]> Co-authored-by: TONG,Zhigao <[email protected]> Co-authored-by: Zhigao Tong <[email protected]> Co-authored-by: TONG, Zhigao <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
…ne or illegal chars (#9255) (#9353) close #8754 Fix the wrong result bug when casting string as datetime with time zone or illegal chars - func `getFracIndex` ignore time zone. - func `parseFrac` ignore illegal suffix after microsecond format. Signed-off-by: Zhigao Tong <[email protected]> Co-authored-by: TONG,Zhigao <[email protected]> Co-authored-by: Zhigao Tong <[email protected]> Co-authored-by: TONG, Zhigao <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
…ne or illegal chars (#9255) (#9351) close #8754 Fix the wrong result bug when casting string as datetime with time zone or illegal chars - func `getFracIndex` ignore time zone. - func `parseFrac` ignore illegal suffix after microsecond format. Signed-off-by: Zhigao Tong <[email protected]> Co-authored-by: TONG,Zhigao <[email protected]> Co-authored-by: Zhigao Tong <[email protected]> Co-authored-by: TONG, Zhigao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #8754
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note