Update components for txn file in serverless #9224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CalvinNeo <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Signed-off-by: CalvinNeo <[email protected]>
ti-chi-bot
bot
added
size/S
Lloyd-Pottiger
approved these changes
Jul 12, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: CalvinNeo <[email protected]>
Co-authored-by: JaySon <[email protected]>
Co-authored-by: JaySon <[email protected]>
yongman
reviewed
Jul 12, 2024
| @@ -39,8 +39,9 @@ struct DecodedLockCFValue : boost::noncopyable | |||
| UInt64 min_commit_ts{0}; | |||
| std::string_view secondaries; | |||
| std::string_view primary_lock; | |||
| bool is_txn_file{false}; | |||
There was a problem hiding this comment.
Better to keep same format with bool use_async_commit{0};
There was a problem hiding this comment.
Suggested change
| bool is_txn_file{false}; | |
| bool is_txn_file{0}; |
There was a problem hiding this comment.
OK, i changed back /cc @JaySon-Huang
JaySon-Huang
approved these changes
Jul 12, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9225
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note