Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fmt error #9199

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix fmt error #9199

merged 1 commit into from
Jul 9, 2024

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #9087

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@windtalker
fix fmt error
3926c19 
Signed-off-by: xufei <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2024
yibin87
yibin87 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 9, 2024
xzhangxian1008
xzhangxian1008 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xzhangxian1008, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 9, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 01:22:52.054444079 +0000 UTC m=+320669.289678188: ☑️ agreed by yibin87.
  • 2024-07-09 01:52:02.700675052 +0000 UTC m=+322419.935909163: ☑️ agreed by xzhangxian1008.

@windtalker
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 38a8d87 into pingcap:master Jul 9, 2024
5 checks passed
JaySon-Huang
JaySon-Huang reviewed Jul 9, 2024
View reviewed changes
dbms/src/Flash/Coprocessor/DAGStorageInterpreter.cpp
@@ -168,7 +168,7 @@ std::tuple<std::optional<RegionRetryList>, RegionException::RegionReadStatus> Ma
throw TiFlashException(
Errors::Coprocessor::BadRequest,
"Income key ranges is illegal, region_id={} version={} conf_version={} request_range=[{}, "
"{}) region_range=[{}, {}}",
"{}) region_range=[{}, {}]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to backport this to release-7.5 and release-8.1
https://github.com/pingcap/tiflash/blob/release-7.5/dbms/src/Flash/Coprocessor/DAGStorageInterpreter.cpp#L152-L157

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jul 9, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9201.

This was referenced Jul 9, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9202.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 9, 2024
@ti-chi-bot @windtalker
fix fmt error (#9199) (#9202)
170693c 
ref #9087

Signed-off-by: xufei <[email protected]>

Co-authored-by: xufei <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 9, 2024
@ti-chi-bot @windtalker
fix fmt error (#9199) (#9201)
890086f 
ref #9087

Signed-off-by: xufei <[email protected]>

Co-authored-by: xufei <[email protected]>
@windtalker windtalker deleted the fix_fmt_error branch December 6, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@windtalker @ti-chi-bot @JaySon-Huang @yibin87 @xzhangxian1008