Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update minimum cmake version to 3.23 (#9164) #9168

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jun 28, 2024

This is an automated cherry-pick of #9164

What problem does this PR solve?

Issue Number: close #9169

ref #8898, ref #7193

Problem Summary:

cmake need to be upgrade to 3.23 at least for building under mac os with clang 14.0.0

What is changed and how it works?

update minimum cmake version to 3.23

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 28, 2024
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.2 labels Jun 28, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 1, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,SeaRise]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Jul 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-01 02:01:29.667279283 +0000 UTC m=+1203416.152768107: ☑️ agreed by JaySon-Huang.
  • 2024-07-01 07:08:12.592239223 +0000 UTC m=+1221819.077728054: ☑️ agreed by SeaRise.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 1, 2024
@JaySon-Huang
Copy link
Contributor

/check-issue-triage

@JaySon-Huang
Copy link
Contributor

/run-check-issue-triage-complete

@purelind
Copy link
Collaborator

purelind commented Jul 2, 2024

/check-issue-triage-complete

@purelind purelind closed this Jul 2, 2024
@purelind purelind reopened this Jul 2, 2024
@purelind
Copy link
Collaborator

purelind commented Jul 2, 2024

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot merged commit 1a9065f into pingcap:release-8.2 Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants