-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Storages: Returns RSResult::Some in MinMaxIndex::CheckIn when has null. #9156
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c045024
to
eb64cbe
Compare
|
||
// Why need return RSResult::Some when a pack has null? | ||
// Take `MinMaxIndex::checkIn` for example. | ||
// There is pack has data [1, 2, 3, 4, null] and a query `... not in (100)`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause ... in (100, 101)
return Some
instead of None
, which may cause performance regression?
@JinheLin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold A new design is working in progress. |
What problem does this PR solve?
Issue Number: ref #9103
What is changed and how it works?
See the comments in code.
Check List
Tests
Side effects
Documentation
Release note