Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storages: Change the element type of use_pack from bool to RSResult in DMFilePackFilter #9145

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Jun 13, 2024

What problem does this PR solve?

Issue Number: ref #9103

What is changed and how it works?

1. Change `std::vector<UInt8> use_packs;` to `std::vector<RSResult> pack_res;`. 
2. Add statistical data of filtering results in `ScanContext`.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 13, 2024
@JinheLin JinheLin changed the title [WIP]Storages: Change the element of use_pack from bool to RSResult in DMFilePackFilter [WIP]Storages: Change the element type of use_pack from bool to RSResult in DMFilePackFilter Jun 13, 2024
@JinheLin
Copy link
Contributor Author

/retest

@JinheLin JinheLin changed the title [WIP]Storages: Change the element type of use_pack from bool to RSResult in DMFilePackFilter Storages: Change the element type of use_pack from bool to RSResult in DMFilePackFilter Jun 13, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 13, 2024
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dbms/src/Storages/DeltaMerge/Index/RSResult.h Outdated Show resolved Hide resolved
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-13 09:20:48.9811205 +0000 UTC m=+629203.034432417: ☑️ agreed by Lloyd-Pottiger.
  • 2024-06-13 10:35:24.631911759 +0000 UTC m=+633678.685223683: ☑️ agreed by JaySon-Huang.

Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2024

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 380a5f3 into pingcap:master Jun 13, 2024
4 of 5 checks passed
@JinheLin JinheLin deleted the use_rs_result branch June 17, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants