*: Fix USE_JEMALLOC macro #9083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CalvinNeo <[email protected]>
ti-chi-bot
bot
added
release-note-none
yibin87
reviewed
May 24, 2024
dbms/src/Common/MemoryAllocTrace.cpp
Outdated
| @@ -16,14 +16,17 @@ | |||
| #include <common/config_common.h> // Included for `USE_JEMALLOC` | |||
|
|
|||
| #ifdef USE_JEMALLOC | |||
| #if USE_JEMALLOC == 1 | |||
There was a problem hiding this comment.
I don't get the point. Why add "#if USE_JEMALLOC == 1" works here? It seems limit the scenarios that include jemalloc head file.
There was a problem hiding this comment.
Because it could be 0, that's why the compile fails
Co-authored-by: Lloyd-Pottiger <[email protected]>
Co-authored-by: Lloyd-Pottiger <[email protected]>
Co-authored-by: Lloyd-Pottiger <[email protected]>
Lloyd-Pottiger
approved these changes
May 24, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Lloyd-Pottiger, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 2, 2024
Co-authored-by: Lloyd-Pottiger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #8835
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note