Storage: Fix page_id being mis-reuse when upgrade from cluster < 6.5 (#9041) #9053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9041
What problem does this PR solve?
Issue Number: close #9039
Problem Summary:
#9039 (comment)
The root cause is:
max_id
for this situation, we must usemax_data_page_id = std::max(data_storage_v2->getMaxId(), data_storage_v3->getMaxId());
to avoid the page_id from being mis-reused. Otherwise it will cause data corruption and make tiflash fails to restart in the next restarttiflash/dbms/src/Storages/DeltaMerge/StoragePool.cpp
Lines 518 to 520 in eb6272c
What is changed and how it works?
StoragePool::restore
, after "meta" and "data" transformed into PSV3, update the max_id by the maximum of that id inPSV2
andPSV3
raiseXXXPageIdLowerBound()
Check List
Tests
alter table ... compact tiflash replica
to make the table has no data in the delta layer (this raises the possibility of the bug happening)alter table ... compact tiflash replica
Side effects
Documentation
Release note