Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline: refactor the extra time calculation in explain analyze (#8987) #9047

Merged
merged 19 commits into from
May 16, 2024
Merged

Pipeline: refactor the extra time calculation in explain analyze (#8987) #9047

merged 19 commits into from
May 16, 2024

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 15, 2024 •
edited by SeaRise
Loading

This is an automated cherry-pick of #8987

What problem does this PR solve?

Issue Number: close #8962

Problem Summary:

What is changed and how it works?

  1. Distribute the pending time evenly across all operators.
  2. add exec_context.getQueryProfileInfo().toJson() to mpp tracing log

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 15, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request May 15, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 15, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2024
SeaRise
SeaRise reviewed May 16, 2024
View reviewed changes
dbms/src/Operators/Operator.cpp Outdated Show resolved Hide resolved
dbms/src/Operators/Operator.h Outdated Show resolved Hide resolved
dbms/src/Operators/Operator.h Outdated Show resolved Hide resolved
dbms/src/Operators/ConcatSourceOp.h Outdated Show resolved Hide resolved
dbms/src/Flash/Pipeline/Schedule/Tasks/Task.h Outdated Show resolved Hide resolved
dbms/src/Flash/Pipeline/Schedule/Tasks/Task.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Pipeline/Schedule/Tasks/SimplePipelineTask.h Outdated Show resolved Hide resolved
dbms/src/Flash/Pipeline/Schedule/Tasks/PipelineTaskBase.h Outdated Show resolved Hide resolved
dbms/src/Flash/Pipeline/Schedule/Tasks/PipelineTask.h Outdated Show resolved Hide resolved
dbms/src/Flash/Pipeline/Schedule/Tasks/PipelineTask.h Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 16, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 16, 2024
@SeaRise
Copy link
Contributor

SeaRise commented May 16, 2024

/cc @JaySon-Huang

@ti-chi-bot ti-chi-bot bot requested a review from JaySon-Huang May 16, 2024 06:46
@SeaRise
Copy link
Contributor

SeaRise commented May 16, 2024

/test all

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

@SeaRise: No jobs can be run with /test all.
The following commands are available to trigger optional jobs:

  • /debug pull-integration-test
  • /debug pull-unit-test

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor

SeaRise commented May 16, 2024

/run-all-tests

@SeaRise
Copy link
Contributor

SeaRise commented May 16, 2024

/run-unit-test

JaySon-Huang
JaySon-Huang approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 16, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,SeaRise]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-16 06:43:52.405675207 +0000 UTC m=+1721986.162810782: ☑️ agreed by SeaRise.
  • 2024-05-16 13:31:28.290217797 +0000 UTC m=+1746442.047353370: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit acdbe72 into pingcap:release-7.5 May 16, 2024
5 checks passed
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@ti-chi-bot @JaySon-Huang
Pipeline: refactor the extra time calculation in explain analyze (pin…
053809e 
…gcap#8987) (pingcap#9047)

close pingcap#8962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@SeaRise SeaRise

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @SeaRise @JaySon-Huang