Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storages: Fix cloning delta index when there are duplicated tuples (release-8.1) (#9000) #9014

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Storages: Fix cloning delta index when there are duplicated tuples (release-8.1) (#9000) #9014

merged 2 commits into from
Apr 30, 2024

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Apr 30, 2024 •
edited
Loading

cherry-pick of #9000 to release-8.1

What problem does this PR solve?

Issue Number: close #8845

What is changed and how it works?

  1. Add a max_dup_tuple_id in DeltaTree.h.
  2. Record the max duplucated tuple id in DeltaPlace.h.
  3. Make sure the snapshot includes all duplicated tuples in the delta index when cloning the delta index in DeltaIndex.h.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the potential issue that tiflash returns transient inconsistent results under high concurrent read

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Apr 30, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 30, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Apr 30, 2024
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 30, 2024
CalvinNeo
CalvinNeo approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 30, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-30 01:49:54.273878993 +0000 UTC m=+321948.031014566: ☑️ agreed by JinheLin.
  • 2024-04-30 02:24:59.074839305 +0000 UTC m=+324052.831974875: ☑️ agreed by CalvinNeo.

@JaySon-Huang JaySon-Huang mentioned this pull request Apr 30, 2024
Closed
12 tasks
@JaySon-Huang
Copy link
Contributor Author

/run-integration-test

1 similar comment
@JaySon-Huang
Copy link
Contributor Author

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit b865587 into pingcap:release-8.1 Apr 30, 2024
5 checks passed
@JaySon-Huang JaySon-Huang deleted the delta_index_test_81 branch April 30, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinheLin JinheLin JinheLin approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JaySon-Huang @CalvinNeo @JinheLin @ti-chi-bot