-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Fix unstable test alter_pk (#8917) #8996
tests: Fix unstable test alter_pk (#8917) #8996
Conversation
/run-all-tests |
/run-all-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-unit-test |
This is an automated cherry-pick of #8917
What problem does this PR solve?
Issue Number: close #8916
Problem Summary:
After executing
alter table test.t add primary key new_pk(a,b,c)
, the table schema is not synced to the latest one when reading from tiflash. Because casting from nullable to not null can be automatically done in the DeltaMergeStore level. So sometime the integration test is not stable. Introduced by #7630What is changed and how it works?
Add
DBGInvoke __refresh_table_schema(test, t2);
to sync the latest schema of tableCheck List
Tests
Side effects
Documentation
Release note