Parallelize the converting hash table to two level process after finishing hash agg build #8957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
ti-chi-bot
bot
added
release-note-none
gengliqi
requested review from
SeaRise and
windtalker
and removed request for
SeaRise
|
/build |
|
/run-all-tests |
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
|
/run-all-tests |
dbms/src/Interpreters/Aggregator.cpp
Outdated
| @@ -2455,14 +2460,55 @@ Block MergingBuckets::getData(size_t concurrency_index) | |||
| { | |||
| assert(concurrency_index < concurrency); | |||
|
|
|||
| if (unlikely(data.empty())) | |||
| if unlikely (data.empty()) | |||
There was a problem hiding this comment.
why removing the () outside of unlikely? 😂
There was a problem hiding this comment.
Just for simplicity😂
SeaRise
reviewed
Apr 19, 2024
Signed-off-by: gengliqi <[email protected]>
ti-chi-bot
bot
added
size/XL
Signed-off-by: gengliqi <[email protected]>
gengliqi
force-pushed
the
parllel-agg-convert
branch
from
3a1dab7 to
6dbbbc3
Compare
Signed-off-by: gengliqi <[email protected]>
|
/run-all-tests |
SeaRise
reviewed
Apr 22, 2024
SeaRise
approved these changes
Apr 23, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/run-all-tests |
windtalker
reviewed
Apr 25, 2024
| @@ -77,6 +84,39 @@ void PhysicalAggregationBuild::buildPipelineExecGroupImpl( | |||
| EventPtr PhysicalAggregationBuild::doSinkComplete(PipelineExecutorContext & exec_context) | |||
| { | |||
| assert(aggregate_context); | |||
|
|
|||
| SCOPE_EXIT({ aggregate_context.reset(); }); | |||
| if (!aggregate_context->hasSpilledData()) | |||
There was a problem hiding this comment.
This check should at least moved to after aggregate_context->getAggSpillContext()->finishSpillableStage(); How about move the whole code block after check AggregateFinalSpillEvent?
Signed-off-by: gengliqi <[email protected]>
|
/run-all-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeaRise, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/run-integration-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #8956
Problem Summary:
See #8956.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note