Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not mark spill if there is no data to spill in auto spill mode #8906

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #8905

Problem Summary:

What is changed and how it works?

Don't mark spill if there is not data to spill in auto spill mode

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2024
@SeaRise SeaRise self-requested a review April 8, 2024 02:32
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 8, 2024
@windtalker windtalker force-pushed the fix_agg_auto_spill_bug branch from f9a6045 to 47f31f5 Compare April 8, 2024 07:24
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-08 02:33:34.569302669 +0000 UTC m=+843276.096843214: ☑️ agreed by SeaRise.
  • 2024-04-08 07:29:22.946105598 +0000 UTC m=+861024.473646138: ☑️ agreed by yibin87.

@windtalker
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

ti-chi-bot bot commented Apr 8, 2024

@windtalker: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@windtalker windtalker force-pushed the fix_agg_auto_spill_bug branch from 2a2393b to 1d91106 Compare April 8, 2024 08:30
@windtalker
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 0b65a2f into pingcap:master Apr 8, 2024
6 checks passed
@windtalker windtalker added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Apr 8, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8912.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregation spill may stuck in infinite loop if an empty hash table is marked to spill
4 participants