Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temp object out of scope issue (#8767) #8830

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8767

What problem does this PR solve?

Issue Number: close #8674

Problem Summary:
When encode enum column, we get the enum name from DataTypeEnum's getNameForValue. However, the return value is a temporary object, and its life scope is limited by the construction of TiDBEnum:
https://github.com/pingcap/tiflash/blob/b9468ccfaa0da1e004b36acfb081b3da4ff2d07e/dbms/src/Flash/Coprocessor/ArrowColCodec.cpp#L350C1-L352C99,
And the name field in TiDBEnum is a constant reference also, which points to the temporary object.
Confirmed this root cause by two steps:

  1. When the crash happen, the getNameForValue still can return the correct name, that means the DataTypeEnum instance memory is not released
  2. The illegal StringRef's char pointer is different from the one inside getNameForValue.

Still not sure why v7.5.0 is not affected by this issue, debug version seems not affected by the issue either.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Mar 6, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2024
12 tasks
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Mar 6, 2024
@JaySon-Huang JaySon-Huang changed the title Fix tem object out of scope issue (#8767) Fix temp object out of scope issue (#8767) Mar 6, 2024
Signed-off-by: yibin <[email protected]>
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 6, 2024
@yibin87
Copy link
Contributor

yibin87 commented Mar 6, 2024

/run-all-tests

1 similar comment
@yibin87
Copy link
Contributor

yibin87 commented Mar 6, 2024

/run-all-tests

@yibin87
Copy link
Contributor

yibin87 commented Mar 6, 2024

/rebuild

@yibin87
Copy link
Contributor

yibin87 commented Mar 6, 2024

/test ?

Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2024

@yibin87: The following commands are available to trigger optional jobs:

  • /debug pull-integration-test
  • /debug pull-unit-test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@yibin87
Copy link
Contributor

yibin87 commented Mar 7, 2024

/run-integration-test

2 similar comments
@yibin87
Copy link
Contributor

yibin87 commented Mar 8, 2024

/run-integration-test

@yibin87
Copy link
Contributor

yibin87 commented Mar 11, 2024

/run-integration-test

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xzhangxian1008, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-06 03:15:39.889227758 +0000 UTC m=+223366.911474147: ☑️ agreed by yibin87.
  • 2024-03-26 02:03:09.924749939 +0000 UTC m=+1947016.946996338: ☑️ agreed by xzhangxian1008.

@yibin87
Copy link
Contributor

yibin87 commented Mar 26, 2024

/run-all-tests

@Lloyd-Pottiger
Copy link
Contributor

/build

@Lloyd-Pottiger
Copy link
Contributor

/run-integration-test

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Mar 26, 2024

There should be something wrong with the test script about handling special chararters in the .test file

Which is fixed in the following branches but not fixed in the release-6.1 branch.

image

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 26, 2024
@yibin87
Copy link
Contributor

yibin87 commented Mar 26, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 7935ce6 into pingcap:release-6.1 Mar 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants