Fix temp object out of scope issue (#8767) #8828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
release-note-none
12 tasks
JaySon-Huang
changed the title
|
/cherry-pick-invite @yibin87 |
|
@yibin87 you're already a collaborator in repo |
Signed-off-by: yibin <[email protected]>
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/run-all-tests |
ti-chi-bot
added
the
cherry-pick-approved
xzhangxian1008
approved these changes
Mar 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xzhangxian1008, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8767
What problem does this PR solve?
Issue Number: close #8674
Problem Summary:
When encode enum column, we get the enum name from DataTypeEnum's getNameForValue. However, the return value is a temporary object, and its life scope is limited by the construction of TiDBEnum:
https://github.com/pingcap/tiflash/blob/b9468ccfaa0da1e004b36acfb081b3da4ff2d07e/dbms/src/Flash/Coprocessor/ArrowColCodec.cpp#L350C1-L352C99,
And the name field in TiDBEnum is a constant reference also, which points to the temporary object.
Confirmed this root cause by two steps:
Still not sure why v7.5.0 is not affected by this issue, debug version seems not affected by the issue either.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note