Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disagg: Set client RPC timeout for FetchDisaggPages #8807

Merged
merged 4 commits into from
Mar 1, 2024
Merged

disagg: Set client RPC timeout for FetchDisaggPages #8807

merged 4 commits into from
Mar 1, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Feb 29, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #8806

What is changed and how it works?

Set client RPC timeout for FetchDisaggPages.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue of tasks waiting indefinitely during network isolated under the disaggregated storage and compute architecture

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 29, 2024
@JinheLin
Copy link
Contributor Author

/run-all-tests

@JinheLin JinheLin requested review from JaySon-Huang, Lloyd-Pottiger and CalvinNeo and removed request for JaySon-Huang February 29, 2024 08:38
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 29, 2024
@JinheLin
Copy link
Contributor Author

JinheLin commented Mar 1, 2024

/run-integration-test

JaySon-Huang
JaySon-Huang reviewed Mar 1, 2024
View reviewed changes
dbms/src/Storages/DeltaMerge/SegmentReadTask.cpp
@@ -551,6 +551,7 @@ void SegmentReadTask::doFetchPages(const disaggregated::FetchDisaggPagesRequest
cluster->rpc_client,
extra_remote_info->store_address);
grpc::ClientContext client_context;
rpc.setClientContext(client_context, dm_context->global_context.getSettingsRef().disagg_fetch_pages_timeout);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we set a timeout for a streaming call, the timeout is to limit the whole process time (until stream_resp->Finish() is called) rather than a timeout for each message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. disagg_fetch_pages_timeout is timeout for the fetching pages of a segment.

@JaySon-Huang JaySon-Huang changed the title Set client RPC timeout for FetchDisaggPages disagg: Set client RPC timeout for FetchDisaggPages Mar 1, 2024
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 1, 2024
JaySon-Huang
JaySon-Huang approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 1, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-29 09:35:09.249830506 +0000 UTC m=+1127397.997453616: ☑️ agreed by Lloyd-Pottiger.
  • 2024-03-01 03:54:51.245471954 +0000 UTC m=+1193379.993095065: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Mar 1, 2024
@JinheLin
Copy link
Contributor Author

JinheLin commented Mar 1, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 1, 2024

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 42dba5e into pingcap:master Mar 1, 2024
6 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 1, 2024
@JinheLin @ti-chi-bot
This is an automated cherry-pick of pingcap#8807
99eed50 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8809.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 1, 2024
Closed
12 tasks
@JinheLin JinheLin mentioned this pull request Mar 5, 2024
Merged
12 tasks
@JaySon-Huang JaySon-Huang mentioned this pull request Apr 18, 2024
Closed
This was referenced Apr 26, 2024
Closed
Closed
Closed
@JinheLin JinheLin deleted the fix_fetch_page_timeout branch April 28, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FetchDisaggPages may wait forever when network partitions happened
4 participants
@JinheLin @ti-chi-bot @JaySon-Huang @Lloyd-Pottiger