-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Fix the storage instance may be physically dropped when the region is not removed #8721
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongyunyan, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
/hold |
/run-all-tests |
/run-unit-test |
/run-all-tests |
/unhold |
/cherry-pick release-7.5 |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
@ti-chi-bot: new pull request could not be created: failed to create pull request against pingcap/tiflash#release-7.5 from head ti-chi-bot:cherry-pick-8721-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-8721-to-release-7.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
This PR also prevent data being unexpected dropped when the region is not removed. Ref #8777 |
What problem does this PR solve?
Issue Number: close #8710
Problem Summary:
There are some case that a region may not be removed from TiFlash when there are unhealth peers rule_checker @ pd. However, after the tiflash replica is set to zero, the data still be physically dropped after gc safepoint exceed.
What is changed and how it works?
* Throw exception when the storage instance is not exist after schema syncedCheck List
Tests
Side effects
Documentation
Release note