Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowerUTF8/upperUTF8 allow lower/uppercase characters occupy different number of bytes (#8622) #8667

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8622

What problem does this PR solve?

Issue Number: close #8484

Problem Summary:
See #8484.

What is changed and how it works?

  1. lowerUTF8/upperUTF8 allow lower/uppercase characters occupy different number of bytes
  2. lowerUTF8/upperUTF8 respect the row boundaries, which means invalid sequences do not influence other rows. Inspired by Do not allow invalid sequences influence other rows in lowerUTF8/upperUTF8 ClickHouse/ClickHouse#41286.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the bug that lowerUTF8/upperUTF8 do not allow lower/uppercase characters occupy different number of bytes

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 5, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 5, 2024
@ti-chi-bot ti-chi-bot closed this Jan 12, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 12, 2024
@XuHuaiyu XuHuaiyu reopened this Jan 12, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2024
Signed-off-by: gengliqi <[email protected]>
@gengliqi gengliqi force-pushed the cherry-pick-8622-to-release-6.5 branch from 566f982 to 3d77ac9 Compare January 24, 2024 07:33
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 24, 2024
@gengliqi
Copy link
Contributor

/run-all-tests

@gengliqi gengliqi requested a review from SeaRise January 24, 2024 07:45
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,gengliqi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-24 07:43:11.209570058 +0000 UTC m=+946632.773867762: ☑️ agreed by gengliqi.
  • 2024-01-24 07:53:36.104607091 +0000 UTC m=+947257.668904797: ☑️ agreed by Lloyd-Pottiger.

Signed-off-by: gengliqi <[email protected]>
@gengliqi
Copy link
Contributor

/run-all-tests

Signed-off-by: gengliqi <[email protected]>
@gengliqi
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit ddea3a4 into pingcap:release-6.5 Jan 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants