PageStorage: avoid redundantly print stale snapshot log #8608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lloyd-Pottiger <[email protected]>
ti-chi-bot
bot
added
release-note-none
JinheLin
reviewed
Dec 27, 2023
Signed-off-by: Lloyd-Pottiger <[email protected]>
JinheLin
approved these changes
Dec 27, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/run-all-tests |
|
/cherry-pick release-6.5 |
|
@JaySon-Huang: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Dec 27, 2023
Signed-off-by: ti-chi-bot <[email protected]>
12 tasks
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Dec 27, 2023
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #6233
Problem Summary:
Usually one TableScan read task can easily involve hundreds of Segments, each of the segment read task acquire a snapshot of PageStorage.
So when there are leaking or long-time running tasks, the logging of "Meet a stale snapshot" will print lots of redundant logging.
What is changed and how it works?
Only print one logging for the same tracing_id
Check List
Tests
Side effects
Documentation
Release note