-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Refine cancel for read thread stream (#8511)" (#8541) #8543
Revert "Refine cancel for read thread stream (#8511)" (#8541) #8543
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, SeaRise The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-all-tests |
/run-integration-test |
/cherry-pick release-6.5-20231215-v6.5.3 |
@gengliqi: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #8541
This reverts commit adf8569.
What problem does this PR solve?
Issue Number: close #8539
Problem Summary:
See #8539
What is changed and how it works?
#8511 introduced an issue that
WorkQueue<Block>
inSegmentReadTaskPool
may not finish forever. Revert this PR to fix this issue for safety and simplicity.Check List
Tests
Side effects
Documentation
Release note