-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Fix corner case of FLASHBACK DATABASE
(#8536)
#8538
Merged
ti-chi-bot
merged 2 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-8536-to-release-7.5
Dec 18, 2023
Merged
ddl: Fix corner case of FLASHBACK DATABASE
(#8536)
#8538
ti-chi-bot
merged 2 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-8536-to-release-7.5
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
labels
Dec 18, 2023
12 tasks
/run-all-tests |
1 similar comment
/run-all-tests |
JaySon-Huang
approved these changes
Dec 18, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Dec 18, 2023
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Dec 18, 2023
Lloyd-Pottiger
approved these changes
Dec 18, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Dec 18, 2023
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8536
What problem does this PR solve?
Issue Number: close #8506
Problem Summary:
If the Region snapshot arrived TiFlash after the database has been dropped, then we can not successfully create the Storage instance because we can not fetch the
DatabaseInfo
from TiKV. And alsoDatabaseInfo
can not be fetch by "mvcc get".tiflash/dbms/src/TiDB/Schema/SchemaBuilder.cpp
Lines 1454 to 1465 in a46271d
What is changed and how it works?
To successfully create a Storage instance (
applyCreateStorageInstance
), we don't need theDatabaseInfo
, aDatabaseID
is sufficient. We are rewriting methods inSchemaBuilder
to replace the methods withDatabaseInfo
byDatabaseID
. So that we can create those Storage instances and decode the Raft logs or snapshots after a database is dropped and the data can be "flashback" later.What's more, avoiding fetching the
DatabaseInfo
from TiKV can speed up syncing schema.For those methods that need the
DatabaseInfo
to get the database name in TiDB to rename tables, we fetch theDatabaseInfo
from the local cache because theapplyDiff
that calls those methods should be applied before the "drop database" SchemaDiff.Add a failpoint to pause pre-handling snapshot for testing.
Check List
Tests
Side effects
Documentation
Release note