-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process streams of partition tables one by one in MultiplexInputStream #8507
Conversation
Signed-off-by: gengliqi <[email protected]>
/run-all-tests |
Can you do some manual tests to show the memory usage with/without this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: SeaRise <[email protected]>
Signed-off-by: gengliqi <[email protected]>
/run-all-tests |
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeaRise, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold |
Signed-off-by: gengliqi <[email protected]>
/unhold |
/run-all-tests |
/run-unit-test |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #8505
Problem Summary:
See #8505.
What is changed and how it works?
In the previous code, many streams of different partition tables may be processed concurrently. This PR simply fixes it by processing streams of partition tables one by one.
Check List
Tests
create a table with 36 partitions.
Test SQL
select * from employees
.Side effects
Documentation
Release note