-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protobuf::internal::AssignDescriptors into tsan.suppression to ignore false positive warning #8499
Conversation
Signed-off-by: yibin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
[LGTM Timeline notifier]Timeline:
|
/approve |
@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeaRise, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yibin87: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #8285
Problem Summary:
Protobuf library uses std::call_once inside protobuf::internal::AssignDescriptors to lazy initialize static global variables exactly once. However, for tsan tests, false positive warnings still can be detected occasionally. It would be caused by inproper compile/link flags or other unknown reasons. It requires uncertain efforts to fix the root cause now, just add it to suppression list to ignore them.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note