-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Support FLASHBACK DATABASE
(release-7.1)
#8449
ddl: Support FLASHBACK DATABASE
(release-7.1)
#8449
Conversation
FLASHBACK DATABASE
(release-7.1)
/run-all-tests |
/run-all-tests |
/hold |
/run-all-tests |
|
/run-integration-test |
/unhold |
/run-all-tests |
/run-all-tests |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongyunyan, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/cherry-pick release-6.5 |
@JaySon-Huang: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #8450
Problem Summary:
tidb support
FLASHBACK DATABASE DBName [TO newDBName]
since v6.4.0 https://docs.pingcap.com/tidb/stable/sql-statement-flashback-databaseHowever, tiflash did not notice that. And if a database is recovered by
FLASHBACK DATABASE
, tiflash can not prevent the data from being removed after gc-safepoint advancedWhat is changed and how it works?
Recover all the tables on the database when
FLASHBACK DATABASE
is executedNote that the implementation is different from that on master, release-7.5. And it can not handle some (rare) cases that raft-logs come after the database is dropped.
Check List
Tests
Side effects
Documentation
Release note