Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the issue that updateStatistics was not called for mlfq in resource group queue #8414

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Fixed the issue that updateStatistics was not called for mlfq in resource group queue #8414

merged 3 commits into from
Nov 23, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Nov 23, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8415

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fixed the issue that updateStatistics was not called for mlfq in resource group queue.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 23, 2023

/cc @windtalker @guo-shaoge

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved and removed do-not-merge/needs-linked-issue labels Nov 23, 2023
windtalker
windtalker approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 23, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-23 07:09:18.334669278 +0000 UTC m=+474586.999895464: ☑️ agreed by guo-shaoge.
  • 2023-11-23 07:35:48.733383568 +0000 UTC m=+476177.398609763: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Nov 23, 2023
@purelind
Copy link
Collaborator

/run-all-tests

@purelind
Copy link
Collaborator

/rebuild

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 23, 2023

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 23, 2023

/run-integration-test

@SeaRise SeaRise force-pushed the fix_update_statistics branch from 773447f to 0a695b5 Compare November 23, 2023 09:06
@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 23, 2023

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

  • Currently the CI jobs are not prow job style, we need it to notify Jenkins server to run them.
  • If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SeaRise,guo-shaoge,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 23, 2023

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 64a03fe into pingcap:master Nov 23, 2023
6 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 23, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8417.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 14, 2023
@ti-chi-bot
Fixed the issue that updateStatistics was not called for mlfq in …
bb119b5 
…`resource group queue` (#8414) (#8417)

close #8415
@SeaRise SeaRise deleted the fix_update_statistics branch January 5, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

updateStatistics was not called for mlfq in resource group queue
5 participants
@SeaRise @purelind @ti-chi-bot @windtalker @guo-shaoge