Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log too many useless information in log #8400

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Don't log too many useless information in log #8400

merged 3 commits into from
Nov 23, 2023

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Nov 21, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8399

Problem Summary:

What is changed and how it works?

  1. for resource_group/conn_id/conn_alias, only log it once at the begining of each request
  2. remove some redundant information in each executor's log identifier

Before this pr, the spill file name in AggregationBuild is

tmp_MPP_gather_id__gather_id_1__query_ts_1700522319105637023__local_query_id_13__server_id_1453__start_ts_445781716263239681__resource_group__default__conn_id__3047162128__conn_alias____task_id_5__Aggregation_HashAgg_80_AggregationBuild_HashAgg_80_aggregation_partition_0_1749

After this pr, the spill file name will be

tmp_MPP_gather_id_1__query_ts_1700522319105637023__local_query_id_13__server_id_1453__start_ts_445781716263239681_task_id_5__AggregationBuild_HashAgg_80_partition_0_1749

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@windtalker
save work
2715fb5 
Signed-off-by: xufei <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2023
@windtalker
save work
92e1c3a 
Signed-off-by: xufei <[email protected]>
xzhangxian1008
xzhangxian1008 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 23, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 23, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-23 00:45:54.536290498 +0000 UTC m=+451583.201516693: ☑️ agreed by xzhangxian1008.
  • 2023-11-23 02:15:08.826047856 +0000 UTC m=+456937.491274049: ☑️ agreed by guo-shaoge.

@windtalker
Copy link
Contributor Author

/run-all-tests

@windtalker
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@windtalker
Copy link
Contributor Author

/run-integration-tests

@ti-chi-bot ti-chi-bot bot merged commit d1949c6 into pingcap:master Nov 23, 2023
@windtalker windtalker deleted the less_information_in_log branch December 28, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spill filename too long error
3 participants
@windtalker @guo-shaoge @xzhangxian1008