Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connection_id and connection_alias in logs #8348

Merged
merged 11 commits into from
Nov 17, 2023
Merged

Add connection_id and connection_alias in logs #8348

merged 11 commits into from
Nov 17, 2023

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #8345

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2023
@xzhangxian1008
Copy link
Contributor Author

/cc @SeaRise @JaySon-Huang

@ti-chi-bot ti-chi-bot bot requested review from JaySon-Huang and SeaRise November 9, 2023 07:56
SeaRise
SeaRise reviewed Nov 9, 2023
View reviewed changes
dbms/src/Flash/FlashService.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTaskId.h Show resolved Hide resolved
JaySon-Huang
JaySon-Huang approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to DisaggTaskId LGTM

dbms/src/Flash/FlashService.cpp Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 9, 2023
JaySon-Huang
JaySon-Huang reviewed Nov 9, 2023
View reviewed changes
dbms/src/Flash/Mpp/MPPTaskId.h
Comment on lines +67 to +68
"<query_ts:{}, local_query_id:{}, server_id:{}, start_ts:{}, resource_group: {}, conn_id: {}, conn_alias: "
"{}>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not related to this PR)
Must we log the resource_group into logging? I think the MPPTaskId is quite long now. It may bring performance regression when there are lots of logging.

@guo-shaoge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think for information like conn_id/conn_alias/resource_group, we can only log it on receiving the request, not log it for every log of during the query

@xzhangxian1008
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2023
SeaRise
SeaRise approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 13, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,SeaRise]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-09 08:04:34.815132977 +0000 UTC m=+3717872.402243122: ☑️ agreed by JaySon-Huang.
  • 2023-11-13 04:54:28.070253546 +0000 UTC m=+4052065.657363690: ☑️ agreed by SeaRise.

@xzhangxian1008
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2023
@xzhangxian1008
Copy link
Contributor Author

/run-tests

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 17, 2023

@xzhangxian1008: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 226b613 into pingcap:master Nov 17, 2023
@xzhangxian1008 xzhangxian1008 deleted the add-identifier branch November 17, 2023 06:33
@windtalker windtalker mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@windtalker windtalker windtalker left review comments

@SeaRise SeaRise SeaRise approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tiflash needs connection id in logs for the convenient of debugging
4 participants
@xzhangxian1008 @windtalker @JaySon-Huang @SeaRise