Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use template to reduce redundant code in min-max index #8298

Merged
merged 11 commits into from
Nov 2, 2023
Merged

Use template to reduce redundant code in min-max index #8298

merged 11 commits into from
Nov 2, 2023

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Nov 2, 2023 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger
remove nan direction
1270850 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
use template
d8220b7 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2023
@Lloyd-Pottiger
refine more
3e7820c 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
move template from struct to function
38d917e 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 2, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/run-unit-test

JaySon-Huang
JaySon-Huang approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dbms/src/Storages/DeltaMerge/Index/MinMaxIndex.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/Index/MinMaxIndex.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/Index/MinMaxIndex.cpp Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 2, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 2, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-02 07:32:26.42483381 +0000 UTC m=+3111144.011943955: ☑️ agreed by JinheLin.
  • 2023-11-02 09:29:37.188101085 +0000 UTC m=+3118174.775211214: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2023
@Lloyd-Pottiger
address comments
0f336a2 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@JaySon-Huang

This comment was marked as resolved.

Sign in to view
@Lloyd-Pottiger
fix a bug
3f37c44 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
fix & add comments
8ee0a62 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 2, 2023
@JaySon-Huang JaySon-Huang removed needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 2, 2023
@Lloyd-Pottiger
fix
39125e6 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 2, 2023
@JaySon-Huang JaySon-Huang removed needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 2, 2023
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@Lloyd-Pottiger
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit b2aefd9 into pingcap:master Nov 2, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/cherry-pick-release-6.5

@Lloyd-Pottiger Lloyd-Pottiger deleted the use-template-to-reduce-redundant-code branch November 2, 2023 12:20
@JaySon-Huang JaySon-Huang mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@JinheLin JinheLin JinheLin approved these changes

@hongyunyan hongyunyan Awaiting requested review from hongyunyan

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lloyd-Pottiger @JaySon-Huang @JinheLin