-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime filter: fix timezone error in runtime filter #8273
Conversation
This pr fix pingcap#8222. The rs operator which is parsed by filter should change the timezone to UTF when the column type is timestamp. The tiflash storage layer store the timestamp type value using UTF. So all of literal include runtime filter values should be changed to UTF timezone.
/cherry-pick release-7.5 |
@elsa0520: once the present PR merges, I will cherry-pick it on top of release-7.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other LGTM
Does this bug affect the release-7.1 branch? @elsa0520 |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
Confirm that this bug does not affect the release-7.1 branch |
Only v7.3 ~v7.5 |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix test cases
[2023-10-30T09:30:08.983Z] fullstack-test/mpp/runtime_filter.test: Running
[2023-10-30T09:30:08.983Z] File: fullstack-test/mpp/runtime_filter.test
[2023-10-30T09:30:08.983Z] Error line: 36
[2023-10-30T09:30:08.983Z] Error: insert into t1_timestamp values (1, "2023-10-20 00:00:00");
[2023-10-30T09:30:08.983Z] Result:
[2023-10-30T09:30:08.983Z] ERROR 1049 (42000): Unknown database '00:00:00);'
[2023-10-30T09:30:08.983Z] Expected:
[2023-10-30T09:30:08.983Z] <nothing>
/approve |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-all-tests |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
This pr fix #8222.
The rs operator which is parsed by filter should change the timezone to UTF when the column type is timestamp.
The tiflash storage layer store the timestamp type value using UTF. So all of literal include runtime filter values should be changed to UTF timezone.
Issue Number: close #8222
Problem Summary:
Check List
Tests
Side effects
Documentation
Release note
Fix version
v7.5