Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disagg: Bump aws sdk #8247

Merged
merged 7 commits into from
Oct 31, 2023
Merged

disagg: Bump aws sdk #8247

merged 7 commits into from
Oct 31, 2023

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Oct 25, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8274

Problem Summary:

Previously we use a fork version of aws-sdk-cpp to workaround aws/aws-sdk-cpp#2476. Now the issue has been fixed on the upstream, we should bump the SDK to the official release version.

What is changed and how it works?

  • Bump aws SDK to v1.11.186
  • Refine some logging level when receive exit signal

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • Tested with sysbench under disagg arch with minio
    • Tested with ch-benchmark under disagg arch with AWS S3
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2023
@JaySon-Huang
cleanup
860de1c 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang JaySon-Huang changed the title [WIP] diagg: Bump aws sdk [WIP] disagg: Bump aws sdk Oct 25, 2023
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Oct 30, 2023
@JaySon-Huang JaySon-Huang changed the title [WIP] disagg: Bump aws sdk disagg: Bump aws sdk Oct 31, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
@JaySon-Huang JaySon-Huang changed the title disagg: Bump aws sdk [WIP] disagg: Bump aws sdk Oct 31, 2023
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 31, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 31, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-31 09:58:19.190175563 +0000 UTC m=+2947096.777285709: ☑️ agreed by JinheLin.
  • 2023-10-31 10:00:37.744498413 +0000 UTC m=+2947235.331608558: ☑️ agreed by Lloyd-Pottiger.

@JaySon-Huang JaySon-Huang changed the title [WIP] disagg: Bump aws sdk disagg: Bump aws sdk Oct 31, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2023
@JaySon-Huang
Copy link
Contributor Author

There is no obvious error observed on AWS S3

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit f3641ae into pingcap:master Oct 31, 2023
@JaySon-Huang JaySon-Huang deleted the update_aws_sdk branch October 31, 2023 15:42
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 31, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8283.

This was referenced Nov 1, 2023
Closed
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 7, 2023
@ti-chi-bot
disagg: Bump aws sdk (#8247) (#8283)
aced292 
close #8274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin JinheLin approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disagg: Should use the official AWS SDK
4 participants
@JaySon-Huang @ti-chi-bot @JinheLin @Lloyd-Pottiger