Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix unstable integration tests (#8205) #8208

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8205

What problem does this PR solve?

Issue Number: close #8206

Problem Summary:

Sometimes we run into error like this, https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-integration-tests/detail/tiflash-ghpr-integration-tests/14731/pipeline

[2023-10-18T04:08:59.291Z] ++ cat ./log/tiflash/server.log
[2023-10-18T04:08:59.291Z] ++ grep 'Ready for connections'
[2023-10-18T04:08:59.291Z] + [[ -n [2023/10/18 12:08:53.086 +08:00] [INFO] [Server.cpp:1660] ["Ready for connections."] [thread_id=1] ]]
[2023-10-18T04:08:59.291Z] + local failed=false
[2023-10-18T04:08:59.291Z] + break
[2023-10-18T04:08:59.291Z] + '[' false == true ']'
[2023-10-18T04:08:59.291Z] + echo '   available'
[2023-10-18T04:08:59.291Z]    available
[2023-10-18T04:08:59.291Z] + docker-compose -f cluster_disable_new_collation.yaml -f tiflash-dt.yaml exec -T tiflash0 bash -c 'cd /tests ; ./run-test.sh tidb-ci/disable_new_collation_fullstack'
[2023-10-18T04:09:02.555Z] tidb-ci/disable_new_collation_fullstack/alter_default_value.test: Running
[2023-10-18T04:09:02.555Z]   File: tidb-ci/disable_new_collation_fullstack/alter_default_value.test
[2023-10-18T04:09:02.555Z]   Error line: 17
[2023-10-18T04:09:02.555Z]   Error: alter table test.t set tiflash replica 1
[2023-10-18T04:09:02.555Z]   Result:
[2023-10-18T04:09:02.555Z]     ERROR 1105 (HY000) at line 1: the tiflash replica count: 1 should be less than the total tiflash server count: 0
[2023-10-18T04:09:02.555Z]   Expected:
[2023-10-18T04:09:02.555Z]     <nothing>

sometimes, https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-integration-tests/detail/tiflash-ghpr-integration-tests/14718/pipeline/291

[2023-10-17T10:10:29.342Z] fullstack-test2/ddl/alter_partition_by.test: Running
[2023-10-17T10:10:39.284Z]   File: fullstack-test2/ddl/alter_partition_by.test
[2023-10-17T10:10:39.284Z]   Error line: 127
[2023-10-17T10:10:39.284Z]   Error: select tidb_database,tidb_name from system.tables where tidb_database = 'test' and tidb_name = 't2' and is_tombstone = 0
[2023-10-17T10:10:39.284Z]   Result:
[2023-10-17T10:10:39.284Z]     <nothing>
[2023-10-17T10:10:39.284Z]   Expected:
[2023-10-17T10:10:39.284Z]     ┌─tidb_database─┬─tidb_name─┐
[2023-10-17T10:10:39.284Z]     │ test          │ t2        │
[2023-10-17T10:10:39.284Z]     └───────────────┴───────────┘

What is changed and how it works?

  • Wait until TiFlash starts by Start to wait for terminal signal
  • Make sure we can read data from tiflash in alter_partition_by.test

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 18, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 18, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,SeaRise]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-18 06:52:30.01445787 +0000 UTC m=+1812747.601568015: ☑️ agreed by SeaRise.
  • 2023-10-18 07:09:29.973464866 +0000 UTC m=+1813767.560574998: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

1 similar comment
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit b39ac1c into pingcap:release-7.5 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants